-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update_agent: support rebase to OCI pullspec #1241
Open
jbtrystram
wants to merge
1
commit into
coreos:main
Choose a base branch
from
jbtrystram:oci_scheme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
force-pushed
the
oci_scheme
branch
2 times, most recently
from
December 4, 2024 14:18
f0713e1
to
1ca8a87
Compare
jbtrystram
changed the title
update_agent: support rebaseing to OCI pullspec
update_agent: support rebase to OCI pullspec
Dec 4, 2024
travier
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very quick look but looks good 👍🏻
cgwalters
reviewed
Dec 4, 2024
dustymabe
reviewed
Dec 9, 2024
jlebon
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's cross-link to coreos/fedora-coreos-tracker#1823 in the commit message for the larger context.
jbtrystram
force-pushed
the
oci_scheme
branch
3 times, most recently
from
December 16, 2024 10:45
4b9c09b
to
11aa880
Compare
Parse rpm-ostree status to detect if the current booted deployment is an OCI image. If so, query the OCI graph for cincinnati and rebase to the correct OCI image. Requires coreos/fedora-coreos-cincinnati#99 and coreos/rpm-ostree#5120 Part of: coreos/fedora-coreos-tracker#1823
jbtrystram
force-pushed
the
oci_scheme
branch
from
December 16, 2024 13:51
11aa880
to
7000352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration knob in
update
to optionnaly use OCI pullspec instead of ostree checksums.This will default to false.
Requires coreos/fedora-coreos-cincinnati#99 and coreos/rpm-ostree#5120